mardi 19 juillet 2016

Is [var = modify(var)] a bad practice?

As a simplified example, given an array of numbers. I need to apply some value filters.

So what I'm doing currently:

Original given array: List<Integer>originalList;

How I construct my filtering methods:

List<Integer> removeNegativeNumber(final List<Integer> numberList) {
 return FluentIterable.from(numberList).filter(rule).toList();
}

How I use:

List<Integer> filteredList = removeNegativeNumber(originalList);
 filteredList = removeOddNumber(filteredList);
 filteredList = removeZeroNumber(filteredList);

My feeling tells me that it can be done better. But I don't know how. Can someone give me advises, recommendations for improving my code ?

Aucun commentaire:

Enregistrer un commentaire